diff options
| author | Amber Brown <hawkowl@atleastfornow.net> | 2018-10-19 21:45:45 +1100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-19 21:45:45 +1100 |
| commit | b69216f7680b92ccd8f92e618e1a81c9ba3c3346 (patch) | |
| tree | f94625c0eeea1a09d3f3e0ff92c685738d054d19 /synapse/notifier.py | |
| parent | Merge pull request #4060 from matrix-org/hawkowl/ssh-key-py3 (diff) | |
| download | synapse-b69216f7680b92ccd8f92e618e1a81c9ba3c3346.tar.xz | |
Make the metrics less racy (#4061)
Diffstat (limited to 'synapse/notifier.py')
| -rw-r--r-- | synapse/notifier.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/synapse/notifier.py b/synapse/notifier.py index 340b16ce25..de02b1017e 100644 --- a/synapse/notifier.py +++ b/synapse/notifier.py @@ -186,9 +186,9 @@ class Notifier(object): def count_listeners(): all_user_streams = set() - for x in self.room_to_user_streams.values(): + for x in list(self.room_to_user_streams.values()): all_user_streams |= x - for x in self.user_to_user_stream.values(): + for x in list(self.user_to_user_stream.values()): all_user_streams.add(x) return sum(stream.count_listeners() for stream in all_user_streams) @@ -196,7 +196,7 @@ class Notifier(object): LaterGauge( "synapse_notifier_rooms", "", [], - lambda: count(bool, self.room_to_user_streams.values()), + lambda: count(bool, list(self.room_to_user_streams.values())), ) LaterGauge( "synapse_notifier_users", "", [], |