summary refs log tree commit diff
path: root/synapse/module_api
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2023-02-22 11:07:28 +0000
committerGitHub <noreply@github.com>2023-02-22 11:07:28 +0000
commit647ff3ef65e7a54b2719755802b4e6f2f45f5eb6 (patch)
treed571c0e3d4ee542e2814ea44b00a936b7fff62a8 /synapse/module_api
parentTweak changelog (diff)
downloadsynapse-647ff3ef65e7a54b2719755802b4e6f2f45f5eb6.tar.xz
Remove unused `room_alias` field from `/createRoom` response (#15093)
* Change `create_room` return type

* Don't return room alias from /createRoom

* Update other callsites

* Fix up mypy complaints

It looks like new_room_user_id is None iff new_room_id is None. It's a
shame we haven't expressed this in a way that mypy can understand.

* Changelog
Diffstat (limited to 'synapse/module_api')
-rw-r--r--synapse/module_api/__init__.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/synapse/module_api/__init__.py b/synapse/module_api/__init__.py
index d22dd19d38..1964276a54 100644
--- a/synapse/module_api/__init__.py
+++ b/synapse/module_api/__init__.py
@@ -1576,14 +1576,14 @@ class ModuleApi:
             )
 
         requester = create_requester(user_id)
-        room_id_and_alias, _ = await self._hs.get_room_creation_handler().create_room(
+        room_id, room_alias, _ = await self._hs.get_room_creation_handler().create_room(
             requester=requester,
             config=config,
             ratelimit=ratelimit,
             creator_join_profile=creator_join_profile,
         )
-
-        return room_id_and_alias["room_id"], room_id_and_alias.get("room_alias", None)
+        room_alias_str = room_alias.to_string() if room_alias else None
+        return room_id, room_alias_str
 
     async def set_displayname(
         self,