diff options
| author | Richard van der Hoff <richard@matrix.org> | 2018-01-27 14:00:11 +0000 |
|---|---|---|
| committer | Richard van der Hoff <richard@matrix.org> | 2018-01-29 17:05:33 +0000 |
| commit | b387ee17b68e4398a8fa26fdf122b773a046e429 (patch) | |
| tree | 840e680214beee50fe117150ddc1847db27d3be2 /synapse/metrics | |
| parent | Merge pull request #2831 from matrix-org/rav/fix-userdir-search-again (diff) | |
| download | synapse-b387ee17b68e4398a8fa26fdf122b773a046e429.tar.xz | |
Improve exception handling in persist_event
1. use `deferred.errback()` instead of `deferred.errback(e)`, which means that a Failure object will be constructed using the current exception state, *including* its stack trace - so the stack trace is saved in the Failure, leading to better exception reports. 2. Set `consumeErrors=True` on the ObservableDeferred, because we know that there will always be at least one observer - which avoids a spurious "CRITICAL: unhandled exception in Deferred" error in the logs
Diffstat (limited to 'synapse/metrics')
0 files changed, 0 insertions, 0 deletions