summary refs log tree commit diff
path: root/synapse/metrics
diff options
context:
space:
mode:
authorreivilibre <oliverw@matrix.org>2022-09-08 14:30:48 +0000
committerGitHub <noreply@github.com>2022-09-08 15:30:48 +0100
commitcf11919ddd4f48b2f59062542ba62969042f80aa (patch)
tree31ec773143715571cf2154c50f04be8f1ddc2a42 /synapse/metrics
parentFix Prometheus recording rules to not use legacy metric names. (#13718) (diff)
downloadsynapse-cf11919ddd4f48b2f59062542ba62969042f80aa.tar.xz
Fix cache metrics not being updated when not using the legacy exposition module. (#13717)
Diffstat (limited to 'synapse/metrics')
-rw-r--r--synapse/metrics/_legacy_exposition.py7
1 files changed, 0 insertions, 7 deletions
diff --git a/synapse/metrics/_legacy_exposition.py b/synapse/metrics/_legacy_exposition.py
index 133f1603dd..563d8cc2c6 100644
--- a/synapse/metrics/_legacy_exposition.py
+++ b/synapse/metrics/_legacy_exposition.py
@@ -34,8 +34,6 @@ from prometheus_client.core import Sample
 from twisted.web.resource import Resource
 from twisted.web.server import Request
 
-from synapse.util import caches
-
 CONTENT_TYPE_LATEST = "text/plain; version=0.0.4; charset=utf-8"
 
 
@@ -107,11 +105,6 @@ def generate_latest(registry: CollectorRegistry, emit_help: bool = False) -> byt
     by prometheus-client.
     """
 
-    # Trigger the cache metrics to be rescraped, which updates the common
-    # metrics but do not produce metrics themselves
-    for collector in caches.collectors_by_name.values():
-        collector.collect()
-
     output = []
 
     for metric in registry.collect():