summary refs log tree commit diff
path: root/synapse/media/oembed.py
diff options
context:
space:
mode:
authordependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>2024-02-06 09:29:17 +0000
committerGitHub <noreply@github.com>2024-02-06 09:29:17 +0000
commit871f51c270726fb76502570dcbf919ce747721d1 (patch)
treeeedf0ed7bd22d8f933ae48146c101a0344234d5d /synapse/media/oembed.py
parentBump dorny/paths-filter from 2 to 3 (#16869) (diff)
downloadsynapse-871f51c270726fb76502570dcbf919ce747721d1.tar.xz
Bump lxml-stubs from 0.4.0 to 0.5.1 (#16885)
Diffstat (limited to 'synapse/media/oembed.py')
-rw-r--r--synapse/media/oembed.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/synapse/media/oembed.py b/synapse/media/oembed.py
index 94ece30459..16d613d271 100644
--- a/synapse/media/oembed.py
+++ b/synapse/media/oembed.py
@@ -256,12 +256,11 @@ def calc_description_and_urls(open_graph_response: JsonDict, html_body: str) ->
     parser = etree.HTMLParser(recover=True, encoding="utf-8")
 
     # Attempt to parse the body. If this fails, log and return no metadata.
-    # TODO Develop of lxml-stubs has this correct.
-    tree = etree.fromstring(html_body, parser)  # type: ignore[arg-type]
+    tree = etree.fromstring(html_body, parser)
 
     # The data was successfully parsed, but no tree was found.
     if tree is None:
-        return  # type: ignore[unreachable]
+        return
 
     # Attempt to find interesting URLs (images, videos, embeds).
     if "og:image" not in open_graph_response: