diff options
| author | Brendan Abolivier <babolivier@matrix.org> | 2019-12-04 14:23:44 +0000 |
|---|---|---|
| committer | Brendan Abolivier <babolivier@matrix.org> | 2019-12-04 14:23:44 +0000 |
| commit | 9dc84b798932d9b0d8f935aca7d65dac3215920e (patch) | |
| tree | 8b5a7838192e91d5f2016f16ae4aa200cdd977db /synapse/logging/_structured.py | |
| parent | Incorporate review (diff) | |
| parent | Add benchmarks for structured logging performance (#6266) (diff) | |
| download | synapse-9dc84b798932d9b0d8f935aca7d65dac3215920e.tar.xz | |
Merge branch 'develop' into babolivier/context_filters
Diffstat (limited to 'synapse/logging/_structured.py')
| -rw-r--r-- | synapse/logging/_structured.py | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/synapse/logging/_structured.py b/synapse/logging/_structured.py index 334ddaf39a..ffa7b20ca8 100644 --- a/synapse/logging/_structured.py +++ b/synapse/logging/_structured.py @@ -261,6 +261,18 @@ def parse_drain_configs( ) +class StoppableLogPublisher(LogPublisher): + """ + A log publisher that can tell its observers to shut down any external + communications. + """ + + def stop(self): + for obs in self._observers: + if hasattr(obs, "stop"): + obs.stop() + + def setup_structured_logging( hs, config, @@ -336,7 +348,7 @@ def setup_structured_logging( # We should never get here, but, just in case, throw an error. raise ConfigError("%s drain type cannot be configured" % (observer.type,)) - publisher = LogPublisher(*observers) + publisher = StoppableLogPublisher(*observers) log_filter = LogLevelFilterPredicate() for namespace, namespace_config in log_config.get( |