summary refs log tree commit diff
path: root/synapse/http/servlet.py
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-04-03 10:40:22 +0100
committerGitHub <noreply@github.com>2020-04-03 10:40:22 +0100
commitdaa1ac89a0be4dd3cc941da4caeb2ddcbd701eff (patch)
tree58ee94b0cfead33ff1aa6cb7420873db994a953c /synapse/http/servlet.py
parentMerge branch 'master' into develop (diff)
downloadsynapse-daa1ac89a0be4dd3cc941da4caeb2ddcbd701eff.tar.xz
Fix device list update stream ids going backward (#7158)
Occasionally we could get a federation device list update transaction which
looked like:

```
[
    {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}},
    {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}},
    {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}}
]
```

Having `stream_ids` which are lower than `prev_ids` looks odd. It might work
(I'm not actually sure), but in any case it doesn't seem like a reasonable
thing to expect other implementations to support.
Diffstat (limited to 'synapse/http/servlet.py')
0 files changed, 0 insertions, 0 deletions