diff options
| author | David Robertson <davidr@element.io> | 2021-09-30 12:51:47 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-30 12:51:47 +0100 |
| commit | 29364145b29e84c5dcab076c4e0d436ebf77e4cd (patch) | |
| tree | 23ef1af431c4629bf973560c86a5cf801e80b3a5 /synapse/handlers | |
| parent | Refactor user directory tests (#10935) (diff) | |
| download | synapse-29364145b29e84c5dcab076c4e0d436ebf77e4cd.tar.xz | |
Pass str to twisted's IReactorTCP (#10895)
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job. Until that change is in a twisted release, we'll have to ignore the type of the `host` argument. I've raised #10899 to remind us to review the issue in a few months' time.
Diffstat (limited to 'synapse/handlers')
| -rw-r--r-- | synapse/handlers/send_email.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/synapse/handlers/send_email.py b/synapse/handlers/send_email.py index 25e6b012b7..1a062a784c 100644 --- a/synapse/handlers/send_email.py +++ b/synapse/handlers/send_email.py @@ -105,8 +105,13 @@ async def _sendmail( # set to enable TLS. factory = build_sender_factory(hostname=smtphost if enable_tls else None) - # the IReactorTCP interface claims host has to be a bytes, which seems to be wrong - reactor.connectTCP(smtphost, smtpport, factory, timeout=30, bindAddress=None) # type: ignore[arg-type] + reactor.connectTCP( + smtphost, # type: ignore[arg-type] + smtpport, + factory, + timeout=30, + bindAddress=None, + ) await make_deferred_yieldable(d) |