diff options
| author | Eric Eastwood <erice@element.io> | 2022-08-23 02:47:30 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-23 08:47:30 +0100 |
| commit | 9385c41ba4fd9cbc86d074ff8fa69e2ae437eb88 (patch) | |
| tree | 475b666ad5ad8ca2cb3ab6cf36aed6b8b6d12a97 /synapse/handlers | |
| parent | `synapse.api.auth.Auth` cleanup: make permission-related methods use `Request... (diff) | |
| download | synapse-9385c41ba4fd9cbc86d074ff8fa69e2ae437eb88.tar.xz | |
Fix Prometheus metrics being negative (mixed up start/end) (#13584)
Fix: - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244
Diffstat (limited to 'synapse/handlers')
| -rw-r--r-- | synapse/handlers/federation.py | 7 | ||||
| -rw-r--r-- | synapse/handlers/federation_event.py | 10 |
2 files changed, 16 insertions, 1 deletions
diff --git a/synapse/handlers/federation.py b/synapse/handlers/federation.py index a09eaa4379..e151962055 100644 --- a/synapse/handlers/federation.py +++ b/synapse/handlers/federation.py @@ -86,9 +86,14 @@ backfill_processing_before_timer = Histogram( "sec", [], buckets=( + 0.1, + 0.5, 1.0, + 2.5, 5.0, + 7.5, 10.0, + 15.0, 20.0, 30.0, 40.0, @@ -482,7 +487,7 @@ class FederationHandler: processing_end_time = self.clock.time_msec() backfill_processing_before_timer.observe( - (processing_start_time - processing_end_time) / 1000 + (processing_end_time - processing_start_time) / 1000 ) success = await try_backfill(likely_domains) diff --git a/synapse/handlers/federation_event.py b/synapse/handlers/federation_event.py index 32326975a1..048c4111f6 100644 --- a/synapse/handlers/federation_event.py +++ b/synapse/handlers/federation_event.py @@ -104,15 +104,25 @@ backfill_processing_after_timer = Histogram( "sec", [], buckets=( + 0.1, + 0.25, + 0.5, 1.0, + 2.5, 5.0, + 7.5, 10.0, + 15.0, 20.0, + 25.0, 30.0, 40.0, + 50.0, 60.0, 80.0, + 100.0, 120.0, + 150.0, 180.0, "+Inf", ), |