Revert "support admin_email config and pass through into blocking errors, return AuthError in all cases"
This reverts commit 0d43f991a19840a224d3dac78d79f13d78212ee6.
1 files changed, 13 insertions, 14 deletions
diff --git a/synapse/handlers/register.py b/synapse/handlers/register.py
index ef7222d7b8..3526b20d5a 100644
--- a/synapse/handlers/register.py
+++ b/synapse/handlers/register.py
@@ -144,8 +144,7 @@ class RegistrationHandler(BaseHandler):
Raises:
RegistrationError if there was a problem registering.
"""
-
- yield self.auth.check_auth_blocking()
+ yield self._check_mau_limits()
password_hash = None
if password:
password_hash = yield self.auth_handler().hash(password)
@@ -290,7 +289,7 @@ class RegistrationHandler(BaseHandler):
400,
"User ID can only contain characters a-z, 0-9, or '=_-./'",
)
- yield self.auth.check_auth_blocking()
+ yield self._check_mau_limits()
user = UserID(localpart, self.hs.hostname)
user_id = user.to_string()
@@ -440,7 +439,7 @@ class RegistrationHandler(BaseHandler):
"""
if localpart is None:
raise SynapseError(400, "Request must include user id")
- yield self.auth.check_auth_blocking()
+ yield self._check_mau_limits()
need_register = True
try:
@@ -535,13 +534,13 @@ class RegistrationHandler(BaseHandler):
action="join",
)
- # @defer.inlineCallbacks
- # def _s(self):
- # """
- # Do not accept registrations if monthly active user limits exceeded
- # and limiting is enabled
- # """
- # try:
- # yield self.auth.check_auth_blocking()
- # except AuthError as e:
- # raise RegistrationError(e.code, str(e), e.errcode)
+ @defer.inlineCallbacks
+ def _check_mau_limits(self):
+ """
+ Do not accept registrations if monthly active user limits exceeded
+ and limiting is enabled
+ """
+ try:
+ yield self.auth.check_auth_blocking()
+ except AuthError as e:
+ raise RegistrationError(e.code, str(e), e.errcode)
|