summary refs log tree commit diff
path: root/synapse/handlers
diff options
context:
space:
mode:
authorSean Quah <8349537+squahtx@users.noreply.github.com>2021-12-15 18:00:48 +0000
committerGitHub <noreply@github.com>2021-12-15 18:00:48 +0000
commitc7fe32edb4da58a262ec37ce6fde7bef95920872 (patch)
tree643f4653b42a18d15c68390c982356341611e7d3 /synapse/handlers
parentRequire Collections as the parameters for simple_* methods. (#11580) (diff)
downloadsynapse-c7fe32edb4da58a262ec37ce6fde7bef95920872.tar.xz
Add type hints to `synapse/storage/databases/main/room.py` (#11575)
Diffstat (limited to 'synapse/handlers')
-rw-r--r--synapse/handlers/room_member.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/synapse/handlers/room_member.py b/synapse/handlers/room_member.py
index 447e3ce571..6aa910dd10 100644
--- a/synapse/handlers/room_member.py
+++ b/synapse/handlers/room_member.py
@@ -1020,7 +1020,7 @@ class RoomMemberHandler(metaclass=abc.ABCMeta):
         # Add new room to the room directory if the old room was there
         # Remove old room from the room directory
         old_room = await self.store.get_room(old_room_id)
-        if old_room and old_room["is_public"]:
+        if old_room is not None and old_room["is_public"]:
             await self.store.set_room_is_public(old_room_id, False)
             await self.store.set_room_is_public(room_id, True)
 
@@ -1031,7 +1031,9 @@ class RoomMemberHandler(metaclass=abc.ABCMeta):
         local_group_ids = await self.store.get_local_groups_for_room(old_room_id)
         for group_id in local_group_ids:
             # Add new the new room to those groups
-            await self.store.add_room_to_group(group_id, room_id, old_room["is_public"])
+            await self.store.add_room_to_group(
+                group_id, room_id, old_room is not None and old_room["is_public"]
+            )
 
             # Remove the old room from those groups
             await self.store.remove_room_from_group(group_id, old_room_id)