summary refs log tree commit diff
path: root/synapse/handlers
diff options
context:
space:
mode:
authorPaul "LeoNerd" Evans <paul@matrix.org>2015-01-13 16:57:28 +0000
committerPaul "LeoNerd" Evans <paul@matrix.org>2015-01-13 16:58:36 +0000
commitc2e7c84e5887de9b622a7cd2cc861f5eef3866c1 (patch)
tree8bb22fc28b8401e38df1b9e946dbbd9852199a74 /synapse/handlers
parentRemove unused functions (diff)
downloadsynapse-c2e7c84e5887de9b622a7cd2cc861f5eef3866c1.tar.xz
Don't try to cancel already-expired timers - SYN-230
Diffstat (limited to 'synapse/handlers')
-rw-r--r--synapse/handlers/typing.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/synapse/handlers/typing.py b/synapse/handlers/typing.py
index 22ce7873d0..cd9638dd04 100644
--- a/synapse/handlers/typing.py
+++ b/synapse/handlers/typing.py
@@ -120,6 +120,10 @@ class TypingNotificationHandler(BaseHandler):
 
         member = RoomMember(room_id=room_id, user=target_user)
 
+        if member in self._member_typing_timer:
+            self.clock.cancel_call_later(self._member_typing_timer[member])
+            del self._member_typing_timer[member]
+
         yield self._stopped_typing(member)
 
     @defer.inlineCallbacks
@@ -142,8 +146,10 @@ class TypingNotificationHandler(BaseHandler):
 
         del self._member_typing_until[member]
 
-        self.clock.cancel_call_later(self._member_typing_timer[member])
-        del self._member_typing_timer[member]
+        if member in self._member_typing_timer:
+            # Don't cancel it - either it already expired, or the real
+            # stopped_typing() will cancel it
+            del self._member_typing_timer[member]
 
     @defer.inlineCallbacks
     def _push_update(self, room_id, user, typing):