summary refs log tree commit diff
path: root/synapse/handlers
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2016-09-06 10:23:38 +0100
committerErik Johnston <erik@matrix.org>2016-09-06 10:23:38 +0100
commit74a3b4a650022a669f528c332f1913161562c7d0 (patch)
tree84bef3f2773c9248e2473be042089162e8125b6a /synapse/handlers
parentMerge pull request #1070 from matrix-org/erikj/presence_stats (diff)
downloadsynapse-74a3b4a650022a669f528c332f1913161562c7d0.tar.xz
Fiddle should_notify to better report stats
Diffstat (limited to '')
-rw-r--r--synapse/handlers/presence.py19
1 files changed, 7 insertions, 12 deletions
diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py
index 7ae05603f5..af389b590f 100644
--- a/synapse/handlers/presence.py
+++ b/synapse/handlers/presence.py
@@ -945,29 +945,24 @@ def should_notify(old_state, new_state):
         notify_reason_counter.inc("status_msg_change")
         return True
 
-    if old_state.state == PresenceState.ONLINE:
-        if new_state.state != PresenceState.ONLINE:
-            # Always notify for online -> anything
-            notify_reason_counter.inc("online_to_not")
-            return True
+    if old_state.state != new_state.state:
+        notify_reason_counter.inc("state_change")
+        return True
 
+    if old_state.state == PresenceState.ONLINE:
         if new_state.currently_active != old_state.currently_active:
             notify_reason_counter.inc("current_active_change")
             return True
 
         if new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
             # Only notify about last active bumps if we're not currently acive
-            if not (old_state.currently_active and new_state.currently_active):
-                notify_reason_counter.inc("last_active_change")
+            if not new_state.currently_active:
+                notify_reason_counter.inc("last_active_change_online")
                 return True
 
     elif new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
         # Always notify for a transition where last active gets bumped.
-        notify_reason_counter.inc("last_active_change")
-        return True
-
-    if old_state.state != new_state.state:
-        notify_reason_counter.inc("state_change")
+        notify_reason_counter.inc("last_active_change_not_online")
         return True
 
     return False