summary refs log tree commit diff
path: root/synapse/handlers/ui_auth
diff options
context:
space:
mode:
authorCallum Brown <callum@calcuode.com>2021-08-18 13:13:35 +0100
committerGitHub <noreply@github.com>2021-08-18 08:13:35 -0400
commit6e613a10d072c32e72d6b97b2d178bb840769f3e (patch)
tree0dec01aa171113e8fc9d5ca5cf7a1069edc50deb /synapse/handlers/ui_auth
parentRefactor `on_receive_pdu` code (#10615) (diff)
downloadsynapse-6e613a10d072c32e72d6b97b2d178bb840769f3e.tar.xz
Display an error page during failure of fallback UIA. (#10561)
Diffstat (limited to 'synapse/handlers/ui_auth')
-rw-r--r--synapse/handlers/ui_auth/checkers.py10
1 files changed, 7 insertions, 3 deletions
diff --git a/synapse/handlers/ui_auth/checkers.py b/synapse/handlers/ui_auth/checkers.py
index 5414ce77d8..270541cc76 100644
--- a/synapse/handlers/ui_auth/checkers.py
+++ b/synapse/handlers/ui_auth/checkers.py
@@ -49,7 +49,7 @@ class UserInteractiveAuthChecker:
             clientip: The IP address of the client.
 
         Raises:
-            SynapseError if authentication failed
+            LoginError if authentication failed.
 
         Returns:
             The result of authentication (to pass back to the client?)
@@ -131,7 +131,9 @@ class RecaptchaAuthChecker(UserInteractiveAuthChecker):
             )
             if resp_body["success"]:
                 return True
-        raise LoginError(401, "", errcode=Codes.UNAUTHORIZED)
+        raise LoginError(
+            401, "Captcha authentication failed", errcode=Codes.UNAUTHORIZED
+        )
 
 
 class _BaseThreepidAuthChecker:
@@ -191,7 +193,9 @@ class _BaseThreepidAuthChecker:
             raise AssertionError("Unrecognized threepid medium: %s" % (medium,))
 
         if not threepid:
-            raise LoginError(401, "", errcode=Codes.UNAUTHORIZED)
+            raise LoginError(
+                401, "Unable to get validated threepid", errcode=Codes.UNAUTHORIZED
+            )
 
         if threepid["medium"] != medium:
             raise LoginError(