diff options
| author | Daniel Wagner-Hall <daniel@matrix.org> | 2016-01-05 18:12:37 +0000 |
|---|---|---|
| committer | review.rocks <nobody@review.rocks> | 2016-01-05 18:12:37 +0000 |
| commit | 2ef6de928d9f0d2761e0664d374b2bfe13682061 (patch) | |
| tree | 8e48e6bd64b001cbb5085b95cf71496777353a0d /synapse/handlers/sync.py | |
| parent | Merge pull request #462 from matrix-org/daniel/guestupgrade (diff) | |
| download | synapse-2ef6de928d9f0d2761e0664d374b2bfe13682061.tar.xz | |
Skip, rather than erroring, invalid guest requests
Erroring causes problems when people make illegal requests, because they don't know what limit parameter they should pass. This is definitely buggy. It leaks message counts for rooms people don't have permission to see, via tokens. But apparently we already consciously decided to allow that as a team, so this preserves that behaviour.
Diffstat (limited to 'synapse/handlers/sync.py')
| -rw-r--r-- | synapse/handlers/sync.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py index 41a42418a9..b63a27b380 100644 --- a/synapse/handlers/sync.py +++ b/synapse/handlers/sync.py @@ -648,7 +648,6 @@ class SyncHandler(BaseHandler): sync_config.user.to_string(), loaded_recents, is_guest=sync_config.is_guest, - require_all_visible_for_guests=False ) loaded_recents.extend(recents) recents = loaded_recents |