summary refs log tree commit diff
path: root/synapse/handlers/search.py
diff options
context:
space:
mode:
authorPatrick Cloke <clokep@users.noreply.github.com>2023-01-09 08:43:50 -0500
committerGitHub <noreply@github.com>2023-01-09 08:43:50 -0500
commit7e582a25f8f350df29d7d83ca902bdb522d1bbaf (patch)
treea624e48b4fbe68dd1dc5c138ce34b82d57d0f3da /synapse/handlers/search.py
parentDisable sending confirmation email when 3pid is disabled #14682 (#14725) (diff)
downloadsynapse-7e582a25f8f350df29d7d83ca902bdb522d1bbaf.tar.xz
Improve /sync performance of when passing filters with empty arrays. (#14786)
This has two related changes:

* It enables fast-path processing for an empty filter (`[]`) which was
  previously only used for wildcard not-filters (`["*"]`).
* It special cases a `/sync` filter with no-rooms to skip all room
  processing, previously we would partially skip processing, but would
  generally still calculate intermediate values for each room which were
  then unused.

Future changes might consider further optimizations:

* Skip calculating per-room account data when all rooms are filtered (currently
  this is thrown away).
* Make similar improvements to other endpoints which support filters.
Diffstat (limited to 'synapse/handlers/search.py')
-rw-r--r--synapse/handlers/search.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/handlers/search.py b/synapse/handlers/search.py
index 33115ce488..40f4635c4e 100644
--- a/synapse/handlers/search.py
+++ b/synapse/handlers/search.py
@@ -275,7 +275,7 @@ class SearchHandler:
         )
         room_ids = {r.room_id for r in rooms}
 
-        # If doing a subset of all rooms seearch, check if any of the rooms
+        # If doing a subset of all rooms search, check if any of the rooms
         # are from an upgraded room, and search their contents as well
         if search_filter.rooms:
             historical_room_ids: List[str] = []