diff options
| author | Daniel Wagner-Hall <daniel@matrix.org> | 2016-01-05 18:12:37 +0000 |
|---|---|---|
| committer | review.rocks <nobody@review.rocks> | 2016-01-05 18:12:37 +0000 |
| commit | 2ef6de928d9f0d2761e0664d374b2bfe13682061 (patch) | |
| tree | 8e48e6bd64b001cbb5085b95cf71496777353a0d /synapse/handlers/room.py | |
| parent | Merge pull request #462 from matrix-org/daniel/guestupgrade (diff) | |
| download | synapse-2ef6de928d9f0d2761e0664d374b2bfe13682061.tar.xz | |
Skip, rather than erroring, invalid guest requests
Erroring causes problems when people make illegal requests, because they don't know what limit parameter they should pass. This is definitely buggy. It leaks message counts for rooms people don't have permission to see, via tokens. But apparently we already consciously decided to allow that as a team, so this preserves that behaviour.
Diffstat (limited to 'synapse/handlers/room.py')
| -rw-r--r-- | synapse/handlers/room.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py index 6186c37c7c..48a07e4e35 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py @@ -895,14 +895,12 @@ class RoomContextHandler(BaseHandler): user.to_string(), results["events_before"], is_guest=is_guest, - require_all_visible_for_guests=False ) results["events_after"] = yield self._filter_events_for_client( user.to_string(), results["events_after"], is_guest=is_guest, - require_all_visible_for_guests=False ) if results["events_after"]: |