diff options
| author | Daniel Wagner-Hall <daniel@matrix.org> | 2016-01-05 18:12:37 +0000 |
|---|---|---|
| committer | Richard van der Hoff <richard@matrix.org> | 2016-01-13 16:41:42 +0000 |
| commit | 93afb40cd4413008c40f6bdde032ccf5f1cefd9f (patch) | |
| tree | 8450163d53161c9ab2b0ffa7d59408a37405669c /synapse/handlers/room.py | |
| parent | Merge pull request #476 from koobs/patch-1 (diff) | |
| download | synapse-93afb40cd4413008c40f6bdde032ccf5f1cefd9f.tar.xz | |
Skip, rather than erroring, invalid guest requests
Erroring causes problems when people make illegal requests, because they don't know what limit parameter they should pass. This is definitely buggy. It leaks message counts for rooms people don't have permission to see, via tokens. But apparently we already consciously decided to allow that as a team, so this preserves that behaviour.
Diffstat (limited to 'synapse/handlers/room.py')
| -rw-r--r-- | synapse/handlers/room.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py index 13f66e0df0..725b318cfe 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py @@ -879,14 +879,12 @@ class RoomContextHandler(BaseHandler): user.to_string(), results["events_before"], is_guest=is_guest, - require_all_visible_for_guests=False ) results["events_after"] = yield self._filter_events_for_client( user.to_string(), results["events_after"], is_guest=is_guest, - require_all_visible_for_guests=False ) if results["events_after"]: |