diff options
| author | Eric Eastwood <erice@element.io> | 2022-08-24 14:13:12 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-24 14:13:12 -0500 |
| commit | d58615c82cec5bd866bedcb33e3e2a5d2a961c44 (patch) | |
| tree | 0c876b95db99f6c927adc011120f6953c38e7d3e /synapse/handlers/room.py | |
| parent | When loading current ids, sort by `stream_id` to avoid incorrect overwrite an... (diff) | |
| download | synapse-d58615c82cec5bd866bedcb33e3e2a5d2a961c44.tar.xz | |
Directly lookup local membership instead of getting all members in a room first (`get_users_in_room` mis-use) (#13608)
See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
Diffstat (limited to 'synapse/handlers/room.py')
| -rw-r--r-- | synapse/handlers/room.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py index 2bf0ebd025..2fc8264858 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py @@ -1284,8 +1284,11 @@ class RoomContextHandler: before_limit = math.floor(limit / 2.0) after_limit = limit - before_limit - users = await self.store.get_users_in_room(room_id) - is_peeking = user.to_string() not in users + is_user_in_room = await self.store.check_local_user_in_room( + user_id=user.to_string(), room_id=room_id + ) + # The user is peeking if they aren't in the room already + is_peeking = not is_user_in_room async def filter_evts(events: List[EventBase]) -> List[EventBase]: if use_admin_priviledge: |