summary refs log tree commit diff
path: root/synapse/handlers/push_rules.py
diff options
context:
space:
mode:
authorPatrick Cloke <clokep@users.noreply.github.com>2023-05-04 07:54:13 -0400
committerGitHub <noreply@github.com>2023-05-04 11:54:13 +0000
commitded8f3d349d8481d1c9a48835cde0b94f785e371 (patch)
tree1a7aec1e9ce0e7c781283133461113936c1e8844 /synapse/handlers/push_rules.py
parentBump pyicu from 2.10.2 to 2.11 (#15509) (diff)
downloadsynapse-ded8f3d349d8481d1c9a48835cde0b94f785e371.tar.xz
Update the base rules to remove the dont_notify action. (MSC3987) (#15534)
A dont_notify action is a no-op (and coalesce is undefined). These are
both considered no-ops by the spec, per MSC3987 and the predefined
push rules were updated to remove dont_notify from the list of actions.
Diffstat (limited to 'synapse/handlers/push_rules.py')
-rw-r--r--synapse/handlers/push_rules.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/synapse/handlers/push_rules.py b/synapse/handlers/push_rules.py
index 1219672a59..813f3aa2d5 100644
--- a/synapse/handlers/push_rules.py
+++ b/synapse/handlers/push_rules.py
@@ -129,6 +129,8 @@ def check_actions(actions: List[Union[str, JsonDict]]) -> None:
         raise InvalidRuleException("No actions found")
 
     for a in actions:
+        # "dont_notify" and "coalesce" are legacy actions. They are allowed, but
+        # ignored (resulting in no action from the pusher).
         if a in ["notify", "dont_notify", "coalesce"]:
             pass
         elif isinstance(a, dict) and "set_tweak" in a: