summary refs log tree commit diff
path: root/synapse/handlers/events.py
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2015-03-06 10:25:36 +0000
committerErik Johnston <erik@matrix.org>2015-03-06 10:25:36 +0000
commit130df8fb01bce1bf244940131d85d1c1a54ed5ef (patch)
treecf15d02559af040e927ac4ace9136fcaf220d530 /synapse/handlers/events.py
parentLog error message when we fail to fetch remote server keys (diff)
downloadsynapse-130df8fb01bce1bf244940131d85d1c1a54ed5ef.tar.xz
Add some randomness to the user specified timeout on event streams to mitigate against thundering herds problems
Diffstat (limited to '')
-rw-r--r--synapse/handlers/events.py9
1 files changed, 9 insertions, 0 deletions
diff --git a/synapse/handlers/events.py b/synapse/handlers/events.py
index 8d5f5c8499..d3297b7292 100644
--- a/synapse/handlers/events.py
+++ b/synapse/handlers/events.py
@@ -23,6 +23,7 @@ from synapse.events.utils import serialize_event
 from ._base import BaseHandler
 
 import logging
+import random
 
 
 logger = logging.getLogger(__name__)
@@ -72,6 +73,14 @@ class EventStreamHandler(BaseHandler):
             rm_handler = self.hs.get_handlers().room_member_handler
             room_ids = yield rm_handler.get_rooms_for_user(auth_user)
 
+            if timeout:
+                # If they've set a timeout set a minimum limit.
+                timeout = max(timeout, 500)
+
+                # Add some randomness to this value to try and mitigate against
+                # thundering herds on restart.
+                timeout = random.randint(int(timeout*0.9), int(timeout*1.1))
+
             with PreserveLoggingContext():
                 events, tokens = yield self.notifier.get_events_for(
                     auth_user, room_ids, pagin_config, timeout