diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-12-06 09:52:55 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-06 09:52:55 +0000 |
| commit | cb59e080627745d089d073d9dac276362d9abaf6 (patch) | |
| tree | 53043ef70d583929c21a774b2449ee8711f6ffce /synapse/handlers/appservice.py | |
| parent | Better return type for `get_all_entities_changed` (#14604) (diff) | |
| download | synapse-cb59e080627745d089d073d9dac276362d9abaf6.tar.xz | |
Improve logging and opentracing for to-device message handling (#14598)
A batch of changes intended to make it easier to trace to-device messages through the system. The intention here is that a client can set a property org.matrix.msgid in any to-device message it sends. That ID is then included in any tracing or logging related to the message. (Suggestions as to where this field should be documented welcome. I'm not enthusiastic about speccing it - it's very much an optional extra to help with debugging.) I've also generally improved the data we send to opentracing for these messages.
Diffstat (limited to 'synapse/handlers/appservice.py')
| -rw-r--r-- | synapse/handlers/appservice.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/synapse/handlers/appservice.py b/synapse/handlers/appservice.py index f68027aaed..5d1d21cdc8 100644 --- a/synapse/handlers/appservice.py +++ b/synapse/handlers/appservice.py @@ -578,9 +578,6 @@ class ApplicationServicesHandler: device_id, ), messages in recipient_device_to_messages.items(): for message_json in messages: - # Remove 'message_id' from the to-device message, as it's an internal ID - message_json.pop("message_id", None) - message_payload.append( { "to_user_id": user_id, |