summary refs log tree commit diff
path: root/synapse/federation
diff options
context:
space:
mode:
authorRichard van der Hoff <github@rvanderhoff.org.uk>2017-10-11 17:29:14 +0100
committerGitHub <noreply@github.com>2017-10-11 17:29:14 +0100
commit8dd0c85ac5ab40cc5c15a5b4b51e35831b2a55b5 (patch)
treea941518269d8dc4a066d0a9863ec4dacd0c757f5 /synapse/federation
parentMerge pull request #2515 from matrix-org/rav/fix_receipt_logcontext (diff)
parentlog pdu_failures from incoming transactions (diff)
downloadsynapse-8dd0c85ac5ab40cc5c15a5b4b51e35831b2a55b5.tar.xz
Merge pull request #2529 from matrix-org/rav/fix_transaction_failure_handling
log pdu_failures from incoming transactions
Diffstat (limited to 'synapse/federation')
-rw-r--r--synapse/federation/federation_server.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/synapse/federation/federation_server.py b/synapse/federation/federation_server.py
index f00d59e701..a8034bddc6 100644
--- a/synapse/federation/federation_server.py
+++ b/synapse/federation/federation_server.py
@@ -211,8 +211,9 @@ class FederationServer(FederationBase):
                     edu.content
                 )
 
-            for failure in getattr(transaction, "pdu_failures", []):
-                logger.info("Got failure %r", failure)
+        pdu_failures = getattr(transaction, "pdu_failures", [])
+        for failure in pdu_failures:
+            logger.info("Got failure %r", failure)
 
         response = {
             "pdus": pdu_results,