diff options
author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-01-04 16:31:32 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-04 16:31:32 +0000 |
commit | 878aa5529399ece8fbb68674a6de86d6958bacae (patch) | |
tree | 67f19ff07959dd6f23edbeea1f391d614293660f /synapse/federation | |
parent | Remove redundant `get_current_events_token` (#11643) (diff) | |
download | synapse-878aa5529399ece8fbb68674a6de86d6958bacae.tar.xz |
`FederationClient.backfill`: stop flagging events as outliers (#11632)
Events returned by `backfill` should not be flagged as outliers. Fixes: ``` AssertionError: null File "synapse/handlers/federation.py", line 313, in try_backfill dom, room_id, limit=100, extremities=extremities File "synapse/handlers/federation_event.py", line 517, in backfill await self._process_pulled_events(dest, events, backfilled=True) File "synapse/handlers/federation_event.py", line 642, in _process_pulled_events await self._process_pulled_event(origin, ev, backfilled=backfilled) File "synapse/handlers/federation_event.py", line 669, in _process_pulled_event assert not event.internal_metadata.is_outlier() ``` See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/231992 Fixes #8894.
Diffstat (limited to 'synapse/federation')
-rw-r--r-- | synapse/federation/federation_client.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py index fee1477ab6..7353c2b6b1 100644 --- a/synapse/federation/federation_client.py +++ b/synapse/federation/federation_client.py @@ -272,7 +272,7 @@ class FederationClient(FederationBase): # Check signatures and hash of pdus, removing any from the list that fail checks pdus[:] = await self._check_sigs_and_hash_and_fetch( - dest, pdus, outlier=True, room_version=room_version + dest, pdus, room_version=room_version ) return pdus |