summary refs log tree commit diff
path: root/synapse/federation/transport
diff options
context:
space:
mode:
authorreivilibre <oliverw@matrix.org>2022-09-14 08:28:12 +0000
committerGitHub <noreply@github.com>2022-09-14 09:28:12 +0100
commit21687ec189f404bcee98ae61b008afc8c5094400 (patch)
tree0e1d9ae29564e170ece531459a3aec4120508047 /synapse/federation/transport
parentMake sequence `cache_invalidation_stream_seq` begin at `2` (#13766) (diff)
downloadsynapse-21687ec189f404bcee98ae61b008afc8c5094400.tar.xz
Fix a long-standing spec compliance bug where Synapse would accept a trailing slash on the end of `/get_missing_events` federation requests. (#13789)
* Don't accept a trailing slash on the end of /get_missing_events

* Newsfile

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
Diffstat (limited to 'synapse/federation/transport')
-rw-r--r--synapse/federation/transport/server/federation.py3
1 files changed, 1 insertions, 2 deletions
diff --git a/synapse/federation/transport/server/federation.py b/synapse/federation/transport/server/federation.py
index f7884bfbe0..6bb4659c4c 100644
--- a/synapse/federation/transport/server/federation.py
+++ b/synapse/federation/transport/server/federation.py
@@ -549,8 +549,7 @@ class FederationClientKeysClaimServlet(BaseFederationServerServlet):
 
 
 class FederationGetMissingEventsServlet(BaseFederationServerServlet):
-    # TODO(paul): Why does this path alone end with "/?" optional?
-    PATH = "/get_missing_events/(?P<room_id>[^/]*)/?"
+    PATH = "/get_missing_events/(?P<room_id>[^/]*)"
 
     async def on_POST(
         self,