diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2021-03-04 16:40:18 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-04 16:40:18 +0000 |
| commit | 8a4b3738f3dcf49f70c08204ad457559dcef4112 (patch) | |
| tree | 8bd53704eba5445498760f74a20538fa90352ef3 /synapse/federation/sender/transaction_manager.py | |
| parent | Prometheus metrics for logins and registrations (#9511) (diff) | |
| download | synapse-8a4b3738f3dcf49f70c08204ad457559dcef4112.tar.xz | |
Replace `last_*_pdu_age` metrics with timestamps (#9540)
Following the advice at https://prometheus.io/docs/practices/instrumentation/#timestamps-not-time-since, it's preferable to export unix timestamps, not ages. There doesn't seem to be any particular naming convention for timestamp metrics.
Diffstat (limited to 'synapse/federation/sender/transaction_manager.py')
| -rw-r--r-- | synapse/federation/sender/transaction_manager.py | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/synapse/federation/sender/transaction_manager.py b/synapse/federation/sender/transaction_manager.py index 763aff296c..2a9cd063c4 100644 --- a/synapse/federation/sender/transaction_manager.py +++ b/synapse/federation/sender/transaction_manager.py @@ -36,9 +36,9 @@ if TYPE_CHECKING: logger = logging.getLogger(__name__) -last_pdu_age_metric = Gauge( - "synapse_federation_last_sent_pdu_age", - "The age (in seconds) of the last PDU successfully sent to the given domain", +last_pdu_ts_metric = Gauge( + "synapse_federation_last_sent_pdu_time", + "The timestamp of the last PDU which was successfully sent to the given domain", labelnames=("server_name",), ) @@ -187,9 +187,8 @@ class TransactionManager: if success and pdus and destination in self._federation_metrics_domains: last_pdu = pdus[-1] - last_pdu_age = self.clock.time_msec() - last_pdu.origin_server_ts - last_pdu_age_metric.labels(server_name=destination).set( - last_pdu_age / 1000 + last_pdu_ts_metric.labels(server_name=destination).set( + last_pdu.origin_server_ts / 1000 ) set_tag(tags.ERROR, not success) |