summary refs log tree commit diff
path: root/synapse/events
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-07-31 16:36:20 +0100
committerErik Johnston <erik@matrix.org>2019-07-31 16:36:20 +0100
commitdc4d74e44adbd8fc79bbaa7ac44b430a11454173 (patch)
tree858a25b95f97d91163b2a50041e9074264e1b513 /synapse/events
parentNewsfile (diff)
downloadsynapse-dc4d74e44adbd8fc79bbaa7ac44b430a11454173.tar.xz
Validate well-known state events are state events.
Lets disallow sending things like memberships, topics etc as non-state
events.
Diffstat (limited to 'synapse/events')
-rw-r--r--synapse/events/validator.py11
1 files changed, 9 insertions, 2 deletions
diff --git a/synapse/events/validator.py b/synapse/events/validator.py
index 29f99361c0..0cf2b9ba42 100644
--- a/synapse/events/validator.py
+++ b/synapse/events/validator.py
@@ -95,10 +95,10 @@ class EventValidator(object):
 
         elif event.type == EventTypes.Topic:
             self._ensure_strings(event.content, ["topic"])
-
+            self._ensure_state_event(event)
         elif event.type == EventTypes.Name:
             self._ensure_strings(event.content, ["name"])
-
+            self._ensure_state_event(event)
         elif event.type == EventTypes.Member:
             if "membership" not in event.content:
                 raise SynapseError(400, "Content has not membership key")
@@ -106,6 +106,7 @@ class EventValidator(object):
             if event.content["membership"] not in Membership.LIST:
                 raise SynapseError(400, "Invalid membership key")
 
+            self._ensure_state_event(event)
         elif event.type == EventTypes.Tombstone:
             if "replacement_room" not in event.content:
                 raise SynapseError(400, "Content has no replacement_room key")
@@ -113,9 +114,15 @@ class EventValidator(object):
             if event.content["replacement_room"] == event.room_id:
                 raise SynapseError(400, "Tombstone cannot reference itself")
 
+            self._ensure_state_event(event)
+
     def _ensure_strings(self, d, keys):
         for s in keys:
             if s not in d:
                 raise SynapseError(400, "'%s' not in content" % (s,))
             if not isinstance(d[s], string_types):
                 raise SynapseError(400, "'%s' not a string type" % (s,))
+
+    def _ensure_state_event(self, event):
+        if not event.is_state():
+            raise SynapseError(400, "'%s' must be state events" % (event.type,))