summary refs log tree commit diff
path: root/synapse/event_auth.py
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2022-11-01 11:47:09 +0000
committerDavid Robertson <davidr@element.io>2022-11-01 11:47:09 +0000
commit9473ebb9e7db9e3f71b341f72ae004db3a0144b8 (patch)
tree07bf4af7dd62408a38b0404e37d9190387b8d765 /synapse/event_auth.py
parentFix type annotation causing import time error in the Complement forking launc... (diff)
downloadsynapse-9473ebb9e7db9e3f71b341f72ae004db3a0144b8.tar.xz
Revert "Fix event size checks (#13710)"
This reverts commit fab495a9e1442d99e922367f65f41de5eaa488eb.

As noted in
https://github.com/matrix-org/synapse/pull/13710#issuecomment-1298396007:

> We want to see this change land for the protocol's sake (and plan to
  un-revert it) but want to give this a little more time before releasing
  this.
Diffstat (limited to 'synapse/event_auth.py')
-rw-r--r--synapse/event_auth.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/synapse/event_auth.py b/synapse/event_auth.py
index 5036604036..bab31e33c5 100644
--- a/synapse/event_auth.py
+++ b/synapse/event_auth.py
@@ -342,15 +342,15 @@ def check_state_dependent_auth_rules(
 
 
 def _check_size_limits(event: "EventBase") -> None:
-    if len(event.user_id.encode("utf-8")) > 255:
+    if len(event.user_id) > 255:
         raise EventSizeError("'user_id' too large")
-    if len(event.room_id.encode("utf-8")) > 255:
+    if len(event.room_id) > 255:
         raise EventSizeError("'room_id' too large")
-    if event.is_state() and len(event.state_key.encode("utf-8")) > 255:
+    if event.is_state() and len(event.state_key) > 255:
         raise EventSizeError("'state_key' too large")
-    if len(event.type.encode("utf-8")) > 255:
+    if len(event.type) > 255:
         raise EventSizeError("'type' too large")
-    if len(event.event_id.encode("utf-8")) > 255:
+    if len(event.event_id) > 255:
         raise EventSizeError("'event_id' too large")
     if len(encode_canonical_json(event.get_pdu_json())) > MAX_PDU_SIZE:
         raise EventSizeError("event too large")