summary refs log tree commit diff
path: root/synapse/appservice
diff options
context:
space:
mode:
authorPaul "LeoNerd" Evans <paul@matrix.org>2016-08-18 14:18:37 +0100
committerPaul "LeoNerd" Evans <paul@matrix.org>2016-08-18 14:18:37 +0100
commit718ffcf8bbf83975a211a1b840de696c0eabec01 (patch)
tree9403b1faadb65db722e6b5941405e0bc3f69e192 /synapse/appservice
parentEnsure that 3PU lookup request fields actually get passed in (diff)
downloadsynapse-718ffcf8bbf83975a211a1b840de696c0eabec01.tar.xz
Since empty lookups now return 200/empty list not 404, we can safely log failures as exceptions
Diffstat (limited to 'synapse/appservice')
-rw-r--r--synapse/appservice/api.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py
index 39b4bff556..e05570cc8b 100644
--- a/synapse/appservice/api.py
+++ b/synapse/appservice/api.py
@@ -78,9 +78,8 @@ class ApplicationServiceApi(SimpleHttpClient):
         try:
             response = yield self.get_json(uri, fields)
             defer.returnValue(response)
-        except Exception:
-            # TODO: would be noisy to log lookup failures, but we want to log
-            # other things. Hrm.
+        except Exception as ex:
+            logger.warning("query_3pu to %s threw exception %s", uri, ex)
             defer.returnValue([])
 
     @defer.inlineCallbacks