diff options
| author | David Robertson <davidr@element.io> | 2023-02-06 12:49:06 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-06 12:49:06 +0000 |
| commit | e8269ed391a199bbe0e43efc28c68c98b949b323 (patch) | |
| tree | 5b9d84f643925b7a92c2e89e7a7db3850714f8fe /synapse/appservice/__init__.py | |
| parent | Bump anyhow from 1.0.68 to 1.0.69 (#14996) (diff) | |
| download | synapse-e8269ed391a199bbe0e43efc28c68c98b949b323.tar.xz | |
Type hints for tests.appservice (#14990)
* Accept a Sequence of events in synapse.appservice This avoids some casts/ignores in the tests I'm about to fixup. It seems that `List[Mock]` is not a subtype of `List[EventBase]`, but `Sequence[Mock]` is a subtype of `Sequence[EventBase]`. So presumably `Mock` is considered a subtype of anything, much like `Any`. * make tests.appservice.test_scheduler pass mypy * Extra hints in tests.appservice.test_scheduler * Extra hints in tests.appservice.test_api * Extra hints in tests.appservice.test_appservice * Disallow untyped defs * Changelog
Diffstat (limited to 'synapse/appservice/__init__.py')
| -rw-r--r-- | synapse/appservice/__init__.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/synapse/appservice/__init__.py b/synapse/appservice/__init__.py index 65615f50b8..35c330a3c4 100644 --- a/synapse/appservice/__init__.py +++ b/synapse/appservice/__init__.py @@ -16,7 +16,7 @@ import logging import re from enum import Enum -from typing import TYPE_CHECKING, Dict, Iterable, List, Optional, Pattern +from typing import TYPE_CHECKING, Dict, Iterable, List, Optional, Pattern, Sequence import attr from netaddr import IPSet @@ -377,7 +377,7 @@ class AppServiceTransaction: self, service: ApplicationService, id: int, - events: List[EventBase], + events: Sequence[EventBase], ephemeral: List[JsonDict], to_device_messages: List[JsonDict], one_time_keys_count: TransactionOneTimeKeysCount, |