diff options
author | David Robertson <davidr@element.io> | 2022-01-25 20:29:28 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-25 15:29:28 -0500 |
commit | 74e4419eb4b18ef7d2a3b4416290a4f103042436 (patch) | |
tree | 69c752a13e0f2feef22b3dfefc77185fd24bd1ac /synapse/app/generic_worker.py | |
parent | Check that `gc` method is available before using in `synapse/app/_base` (#11... (diff) | |
download | synapse-74e4419eb4b18ef7d2a3b4416290a4f103042436.tar.xz |
Fix another jsonschema typecheck error (#11830)
Similar to #11817. In `_create_power_level_validator` we - retrieve `validator`. This is a class implementing the `jsonschema.protocols.Validator` interface. In other words, `validator: Type[jsonschema.protocols.Validator]`. - we then create an second validator class by modifying the original `validator`. We return that class, which is also of type `Type[jsonschema.protocols.Validator]`. So the original annotation was incorrect: it claimed we were returning an instance of jsonSchema.Draft7Validator, not the class (or a subclass) itself. (Strictly speaking this is incorrect, because `POWER_LEVELS_SCHEMA` isn't pinned to a particular version of JSON Schema. But there are other complications with the type stubs if you try to fix this; I felt like the change herein was a decent compromise that better expresses intent). (I suspect/hope the typeshed project would welcome an effort to improve the jsonschema stubs. Let's see if I get some spare time.)
Diffstat (limited to 'synapse/app/generic_worker.py')
0 files changed, 0 insertions, 0 deletions