summary refs log tree commit diff
path: root/synapse/app/federation_reader.py
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2018-08-28 13:39:49 +0100
committerRichard van der Hoff <richard@matrix.org>2018-08-28 13:39:49 +0100
commit0b07f02e19e5ed1eba0e74c3863def9f849b5f9a (patch)
treedd17eca36b5b169dc25b309631b4522b3d516cc7 /synapse/app/federation_reader.py
parentMerge pull request #3758 from matrix-org/erikj/admin_contact (diff)
downloadsynapse-0b07f02e19e5ed1eba0e74c3863def9f849b5f9a.tar.xz
Make sure that we close db connections opened during init
We should explicitly close any db connections we open, because failing to do so
can block other transactions as per
https://github.com/matrix-org/synapse/issues/3682.

Let's also try to factor out some of the boilerplate by having server classes
define their datastore class rather than duplicating the whole of `setup`.
Diffstat (limited to 'synapse/app/federation_reader.py')
-rw-r--r--synapse/app/federation_reader.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/synapse/app/federation_reader.py b/synapse/app/federation_reader.py
index 7d8105778d..60f5973505 100644
--- a/synapse/app/federation_reader.py
+++ b/synapse/app/federation_reader.py
@@ -72,10 +72,7 @@ class FederationReaderSlavedStore(
 
 
 class FederationReaderServer(HomeServer):
-    def setup(self):
-        logger.info("Setting up.")
-        self.datastore = FederationReaderSlavedStore(self.get_db_conn(), self)
-        logger.info("Finished setting up.")
+    DATASTORE_CLASS = FederationReaderSlavedStore
 
     def _listen_http(self, listener_config):
         port = listener_config["port"]