diff options
| author | Richard van der Hoff <richard@matrix.org> | 2018-08-28 13:39:49 +0100 |
|---|---|---|
| committer | Richard van der Hoff <richard@matrix.org> | 2018-08-28 13:39:49 +0100 |
| commit | 0b07f02e19e5ed1eba0e74c3863def9f849b5f9a (patch) | |
| tree | dd17eca36b5b169dc25b309631b4522b3d516cc7 /synapse/app/appservice.py | |
| parent | Merge pull request #3758 from matrix-org/erikj/admin_contact (diff) | |
| download | synapse-0b07f02e19e5ed1eba0e74c3863def9f849b5f9a.tar.xz | |
Make sure that we close db connections opened during init
We should explicitly close any db connections we open, because failing to do so can block other transactions as per https://github.com/matrix-org/synapse/issues/3682. Let's also try to factor out some of the boilerplate by having server classes define their datastore class rather than duplicating the whole of `setup`.
Diffstat (limited to 'synapse/app/appservice.py')
| -rw-r--r-- | synapse/app/appservice.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/synapse/app/appservice.py b/synapse/app/appservice.py index 3348a8ec6d..86b5067400 100644 --- a/synapse/app/appservice.py +++ b/synapse/app/appservice.py @@ -51,10 +51,7 @@ class AppserviceSlaveStore( class AppserviceServer(HomeServer): - def setup(self): - logger.info("Setting up.") - self.datastore = AppserviceSlaveStore(self.get_db_conn(), self) - logger.info("Finished setting up.") + DATASTORE_CLASS = AppserviceSlaveStore def _listen_http(self, listener_config): port = listener_config["port"] |