summary refs log tree commit diff
path: root/synapse/api/errors.py
diff options
context:
space:
mode:
authorMark Haines <mark.haines@matrix.org>2014-11-20 17:10:37 +0000
committerMark Haines <mark.haines@matrix.org>2014-11-20 17:10:37 +0000
commitdfdda2c8718b11bff9eb69d382eff72c9f8a3d79 (patch)
tree23b5cb61864bcffc5a0fd371758bf97febcd0367 /synapse/api/errors.py
parentAdd a few missing yields, Move deferred lists inside PreserveLoggingContext b... (diff)
downloadsynapse-dfdda2c8718b11bff9eb69d382eff72c9f8a3d79.tar.xz
Use module loggers rather than the root logger. Exceptions caused by bad clients shouldn't cause ERROR level logging. Fix sql logging to use 'repr' rather than 'str'
Diffstat (limited to 'synapse/api/errors.py')
-rw-r--r--synapse/api/errors.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/synapse/api/errors.py b/synapse/api/errors.py
index 33d15072af..581439ceb3 100644
--- a/synapse/api/errors.py
+++ b/synapse/api/errors.py
@@ -17,6 +17,8 @@
 
 import logging
 
+logger = logging.getLogger(__name__)
+
 
 class Codes(object):
     UNAUTHORIZED = "M_UNAUTHORIZED"
@@ -38,7 +40,7 @@ class CodeMessageException(Exception):
     """An exception with integer code and message string attributes."""
 
     def __init__(self, code, msg):
-        logging.error("%s: %s, %s", type(self).__name__, code, msg)
+        logger.info("%s: %s, %s", type(self).__name__, code, msg)
         super(CodeMessageException, self).__init__("%d: %s" % (code, msg))
         self.code = code
         self.msg = msg
@@ -140,7 +142,8 @@ def cs_exception(exception):
     if isinstance(exception, CodeMessageException):
         return exception.error_dict()
     else:
-        logging.error("Unknown exception type: %s", type(exception))
+        logger.error("Unknown exception type: %s", type(exception))
+        return {}
 
 
 def cs_error(msg, code=Codes.UNKNOWN, **kwargs):