diff options
| author | David Robertson <davidr@element.io> | 2022-04-27 14:03:44 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-27 14:03:44 +0100 |
| commit | 646324437543c096e737777c81b4fe4b45c3e1a7 (patch) | |
| tree | 5320ddebe74982e1ff8ba427e45ef27135565699 /stubs | |
| parent | Consistently use collections.abc.Mapping to check frozendict. (#12564) (diff) | |
| download | synapse-646324437543c096e737777c81b4fe4b45c3e1a7.tar.xz | |
Remove unused `# type: ignore`s (#12531)
Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.
Diffstat (limited to 'stubs')
| -rw-r--r-- | stubs/sortedcontainers/sorteddict.pyi | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/stubs/sortedcontainers/sorteddict.pyi b/stubs/sortedcontainers/sorteddict.pyi index e18d617281..3a4f9c3076 100644 --- a/stubs/sortedcontainers/sorteddict.pyi +++ b/stubs/sortedcontainers/sorteddict.pyi @@ -115,9 +115,7 @@ class SortedKeysView(KeysView[_KT_co], Sequence[_KT_co]): def __getitem__(self, index: slice) -> List[_KT_co]: ... def __delitem__(self, index: Union[int, slice]) -> None: ... -class SortedItemsView( # type: ignore - ItemsView[_KT_co, _VT_co], Sequence[Tuple[_KT_co, _VT_co]] -): +class SortedItemsView(ItemsView[_KT_co, _VT_co], Sequence[Tuple[_KT_co, _VT_co]]): def __iter__(self) -> Iterator[Tuple[_KT_co, _VT_co]]: ... @overload def __getitem__(self, index: int) -> Tuple[_KT_co, _VT_co]: ... |