summary refs log tree commit diff
path: root/scripts-dev/lint.sh
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2022-04-14 11:33:06 +0100
committerGitHub <noreply@github.com>2022-04-14 11:33:06 +0100
commit535a689cfcec896dd4ce74ef567bd30c11ade9e3 (patch)
tree60c824ae35300f8e788c5d08a6256f9926cd4ca6 /scripts-dev/lint.sh
parentUse `poetry` to manage the virtualenv in debian packages (#12449) (diff)
downloadsynapse-535a689cfcec896dd4ce74ef567bd30c11ade9e3.tar.xz
Reintroduce the lint targets in the linter script (#12455)
Diffstat (limited to 'scripts-dev/lint.sh')
-rwxr-xr-xscripts-dev/lint.sh16
1 files changed, 14 insertions, 2 deletions
diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh
index 4698d2d5be..91a704d982 100755
--- a/scripts-dev/lint.sh
+++ b/scripts-dev/lint.sh
@@ -79,8 +79,20 @@ else
   # If we were not asked to lint changed files, and no paths were found as a result,
   # then lint everything!
   if [[ -z ${files+x} ]]; then
-    # Lint all source code files and directories
-      files=( "." )
+      # CI runs each linter on the entire checkout, e.g. `black .`. So don't
+      # rely on this list to *find* lint targets if that misses a file; instead;
+      # use it to exclude files from linters when this can't be done by config.
+      #
+      # To check which files the linters examine, use:
+      #     black --verbose . 2>&1 | \grep -v ignored
+      #     isort --show-files .
+      #     flake8 --verbose .  # This isn't a great option
+      #     mypy has explicit config in mypy.ini; there is also mypy --verbose
+      files=(
+          "synapse" "docker" "tests"
+          "scripts-dev"
+          "contrib" "setup.py" "synmark" "stubs" ".ci"
+      )
   fi
 fi