diff options
| author | Dan Callahan <danc@element.io> | 2021-10-22 22:46:06 +0100 |
|---|---|---|
| committer | Dan Callahan <danc@element.io> | 2021-10-22 23:08:54 +0100 |
| commit | 13f084eb58c379b2fc073680818d5931e94626f4 (patch) | |
| tree | fb5d41ac9612ff43394d7d1d722d30e45aa4df1a /scripts-dev/check-newsfragment | |
| parent | Fix Shellcheck SC2012: Use find instead of ls (diff) | |
| download | synapse-13f084eb58c379b2fc073680818d5931e94626f4.tar.xz | |
Fix Shellcheck SC2086: Quote to prevent splitting
Double quote to prevent globbing and word splitting. https://github.com/koalaman/shellcheck/wiki/SC2086 Signed-off-by: Dan Callahan <danc@element.io>
Diffstat (limited to 'scripts-dev/check-newsfragment')
| -rwxr-xr-x | scripts-dev/check-newsfragment | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts-dev/check-newsfragment b/scripts-dev/check-newsfragment index 56600de0ad..5fc68e3213 100755 --- a/scripts-dev/check-newsfragment +++ b/scripts-dev/check-newsfragment @@ -44,8 +44,8 @@ echo matched=0 for f in `git diff --name-only FETCH_HEAD... -- changelog.d`; do # check that any modified newsfiles on this branch end with a full stop. - lastchar=`tr -d '\n' < $f | tail -c 1` - if [ $lastchar != '.' ] && [ $lastchar != '!' ]; then + lastchar=`tr -d '\n' < "$f" | tail -c 1` + if [ "$lastchar" != '.' ] && [ "$lastchar" != '!' ]; then echo -e "\e[31mERROR: newsfragment $f does not end with a '.' or '!'\e[39m" >&2 echo -e "$CONTRIBUTING_GUIDE_TEXT" >&2 exit 1 |