diff options
| author | Mark Haines <mark.haines@matrix.org> | 2016-05-16 12:59:41 +0100 |
|---|---|---|
| committer | Mark Haines <mark.haines@matrix.org> | 2016-05-16 12:59:41 +0100 |
| commit | dd95eb4cb5f1519bfd328249f97f8731c4a11b64 (patch) | |
| tree | 96220dc54d2d6d0b36999c5c01db8d5f5b13b851 /docs | |
| parent | add a url_preview_ip_range_whitelist config param so we can whitelist the mat... (diff) | |
| parent | fix logo (diff) | |
| download | synapse-dd95eb4cb5f1519bfd328249f97f8731c4a11b64.tar.xz | |
Merge branch 'develop' into matthew/preview_url_ip_whitelist
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/log_contexts.rst | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/docs/log_contexts.rst b/docs/log_contexts.rst new file mode 100644 index 0000000000..0046e171be --- /dev/null +++ b/docs/log_contexts.rst @@ -0,0 +1,10 @@ +What do I do about "Unexpected logging context" debug log-lines everywhere? + +<Mjark> The logging context lives in thread local storage +<Mjark> Sometimes it gets out of sync with what it should actually be, usually because something scheduled something to run on the reactor without preserving the logging context. +<Matthew> what is the impact of it getting out of sync? and how and when should we preserve log context? +<Mjark> The impact is that some of the CPU and database metrics will be under-reported, and some log lines will be mis-attributed. +<Mjark> It should happen auto-magically in all the APIs that do IO or otherwise defer to the reactor. +<Erik> Mjark: the other place is if we branch, e.g. using defer.gatherResults + +Unanswered: how and when should we preserve log context? \ No newline at end of file |