summary refs log tree commit diff
path: root/docs
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2017-09-20 01:32:42 +0100
committerRichard van der Hoff <richard@matrix.org>2017-09-20 01:32:42 +0100
commitc5c24c239b63d06a6e312d86c338da60cfcee814 (patch)
tree77988a5e3b47a1d1db247d6a74655f8a00939cf6 /docs
parentTurn _start_key_lookups into an inlineCallbacks function (diff)
downloadsynapse-c5c24c239b63d06a6e312d86c338da60cfcee814.tar.xz
Fix logcontext handling in verify_json_objects_for_server
preserve_context_over_fn is essentially broken, because (a) it pointlessly
drops the current logcontext before calling its wrapped function, which means
we don't get any useful logcontexts for _handle_key_deferred; (b) it wraps the
resulting deferred in a _PreservingContextDeferred, which is very dangerous
because you then can't yield on it without leaking context back into the
reactor.

Instead, let's specify that the resultant deferreds call their callbacks with
no logcontext.
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions