summary refs log tree commit diff
path: root/docs/log_contexts.rst
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2018-03-07 19:59:24 +0000
committerRichard van der Hoff <richard@matrix.org>2018-03-08 11:50:11 +0000
commit20f40348d4ea55cc5b98528673e26bac7396a3cb (patch)
treea577c87955428747c13bab6c6c11cb3727e75426 /docs/log_contexts.rst
parentMerge pull request #2949 from krombel/use_bcrypt_checkpw (diff)
downloadsynapse-20f40348d4ea55cc5b98528673e26bac7396a3cb.tar.xz
Factor run_in_background out from preserve_fn
It annoys me that we create temporary function objects when there's really no
need for it. Let's factor the gubbins out of preserve_fn and start using it.
Diffstat (limited to 'docs/log_contexts.rst')
-rw-r--r--docs/log_contexts.rst8
1 files changed, 4 insertions, 4 deletions
diff --git a/docs/log_contexts.rst b/docs/log_contexts.rst
index b19b7fa1ea..82ac4f91e5 100644
--- a/docs/log_contexts.rst
+++ b/docs/log_contexts.rst
@@ -279,9 +279,9 @@ Obviously that option means that the operations done in
 that might be fixed by setting a different logcontext via a ``with
 LoggingContext(...)`` in ``background_operation``).
 
-The second option is to use ``logcontext.preserve_fn``, which wraps a function
-so that it doesn't reset the logcontext even when it returns an incomplete
-deferred, and adds a callback to the returned deferred to reset the
+The second option is to use ``logcontext.run_in_background``, which wraps a
+function so that it doesn't reset the logcontext even when it returns an
+incomplete deferred, and adds a callback to the returned deferred to reset the
 logcontext. In other words, it turns a function that follows the Synapse rules
 about logcontexts and Deferreds into one which behaves more like an external
 function — the opposite operation to that described in the previous section.
@@ -293,7 +293,7 @@ It can be used like this:
     def do_request_handling():
         yield foreground_operation()
 
-        logcontext.preserve_fn(background_operation)()
+        logcontext.run_in_background(background_operation)
 
         # this will now be logged against the request context
         logger.debug("Request handling complete")