summary refs log tree commit diff
path: root/docs/log_contexts.rst
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2016-05-04 19:08:27 +0100
committerErik Johnston <erik@matrix.org>2016-05-04 19:08:27 +0100
commitfee1118a207f1f07f21c3b8bf52d40c4f891bbcb (patch)
treec563ec6102a9899981b51bfc51945a3d9baef664 /docs/log_contexts.rst
parentImplement basic ignore user (diff)
parentMerge pull request #762 from matrix-org/erikj/report_event (diff)
downloadsynapse-fee1118a207f1f07f21c3b8bf52d40c4f891bbcb.tar.xz
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/ignore_user
Diffstat (limited to 'docs/log_contexts.rst')
-rw-r--r--docs/log_contexts.rst10
1 files changed, 10 insertions, 0 deletions
diff --git a/docs/log_contexts.rst b/docs/log_contexts.rst
new file mode 100644
index 0000000000..0046e171be
--- /dev/null
+++ b/docs/log_contexts.rst
@@ -0,0 +1,10 @@
+What do I do about "Unexpected logging context" debug log-lines everywhere?
+
+<Mjark> The logging context lives in thread local storage
+<Mjark> Sometimes it gets out of sync with what it should actually be, usually because something scheduled something to run on the reactor without preserving the logging context. 
+<Matthew> what is the impact of it getting out of sync? and how and when should we preserve log context?
+<Mjark> The impact is that some of the CPU and database metrics will be under-reported, and some log lines will be mis-attributed.
+<Mjark> It should happen auto-magically in all the APIs that do IO or otherwise defer to the reactor.
+<Erik> Mjark: the other place is if we branch, e.g. using defer.gatherResults
+
+Unanswered: how and when should we preserve log context?
\ No newline at end of file