diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-01-17 12:14:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-17 12:14:40 +0000 |
| commit | 6a78ede56932b486c0ca3cc7c6edd84a2f373366 (patch) | |
| tree | dcfe2e7e2ba0acf0f7e23a741b5b4b8333e12f8e /changelog.d | |
| parent | Make pagination of rooms in admin api stable (#11737) (diff) | |
| download | synapse-6a78ede56932b486c0ca3cc7c6edd84a2f373366.tar.xz | |
Improve `reactor_tick_time` metric (#11724)
The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it *only* measures the time taken to execute timed calls and callbacks from threads. That neglects everything that happens off the back of I/O, which is obviously quite a lot for us. To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is the only place it should wait for something to happen - the rest of the loop *should* be quick. I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and it's a nuisance to populate.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/11724.misc | 1 | ||||
| -rw-r--r-- | changelog.d/11724.removal | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/changelog.d/11724.misc b/changelog.d/11724.misc new file mode 100644 index 0000000000..e9d5dae857 --- /dev/null +++ b/changelog.d/11724.misc @@ -0,0 +1 @@ +Improve accuracy of `python_twisted_reactor_tick_time` prometheus metric. diff --git a/changelog.d/11724.removal b/changelog.d/11724.removal new file mode 100644 index 0000000000..088c3ff31f --- /dev/null +++ b/changelog.d/11724.removal @@ -0,0 +1 @@ +Remove `python_twisted_reactor_pending_calls` prometheus metric. |