diff options
| author | David Baker <dbkr@users.noreply.github.com> | 2019-06-18 22:51:24 +0100 |
|---|---|---|
| committer | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-06-18 22:51:24 +0100 |
| commit | f2d2ae03dae519a4f2035f1466fdd3429c71edc8 (patch) | |
| tree | 313bf881fe0583a5129ed0e472667e6be566b6d4 /changelog.d | |
| parent | Fix seven contrib files with Python syntax errors (#5446) (diff) | |
| download | synapse-f2d2ae03dae519a4f2035f1466fdd3429c71edc8.tar.xz | |
Add some logging to 3pid invite sig verification (#5015)
I had to add quite a lot of logging to diagnose a problem with 3pid invites - we only logged the one failure which isn't all that informative. NB. I'm not convinced the logic of this loop is right: I think it should just accept a single valid signature from a trusted source rather than fail if *any* signature is invalid. Also it should probably not skip the rest of middle loop if a check fails? However, I'm deliberately not changing the logic here.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/5015.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/5015.misc b/changelog.d/5015.misc new file mode 100644 index 0000000000..eeec85b92c --- /dev/null +++ b/changelog.d/5015.misc @@ -0,0 +1 @@ +Add logging to 3pid invite signature verification. |