diff options
| author | Eric Eastwood <erice@element.io> | 2021-07-29 03:46:51 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-29 09:46:51 +0100 |
| commit | db6e7f15eaee81be54b960d040102900f20e3f74 (patch) | |
| tree | 01f877c02077d9b1d8bdf2541da9e229d62ebd11 /changelog.d | |
| parent | Generics for `ObservableDeferred` (#10491) (diff) | |
| download | synapse-db6e7f15eaee81be54b960d040102900f20e3f74.tar.xz | |
Fix backfilled events being rejected for no `state_groups` (#10439)
Reproducible on a federated homeserver when there is a membership auth event as a floating outlier. Then when we try to backfill one of that persons messages, it has missing membership auth to fetch which caused us to mistakenly replace the `context` for the message with that of the floating membership `outlier` event. Since `outliers` have no `state` or `state_group`, the error bubbles up when we continue down the persisting route: `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group` Call stack: ``` backfill _auth_and_persist_event _check_event_auth _update_auth_events_and_context_for_auth ```
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/10439.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/10439.bugfix b/changelog.d/10439.bugfix new file mode 100644 index 0000000000..74e5a25126 --- /dev/null +++ b/changelog.d/10439.bugfix @@ -0,0 +1 @@ +Fix events with floating outlier state being rejected over federation. |