summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2020-07-10 18:15:35 +0100
committerGitHub <noreply@github.com>2020-07-10 18:15:35 +0100
commite29c44340bce07d77c824af7c9bebed04e28ad1e (patch)
tree3ebe94f9e4d0926fd257884f83de15270b8dbea1 /changelog.d
parent1.17.0rc1 (diff)
downloadsynapse-e29c44340bce07d77c824af7c9bebed04e28ad1e.tar.xz
Fix recursion error when fetching auth chain over federation (#7817)
When fetching the state of a room over federation we receive the event
IDs of the state and auth chain. We then fetch those events that we
don't already have.

However, we used a function that recursively fetched any missing auth
events for the fetched events, which can lead to a lot of recursion if
the server is missing most of the auth chain. This work is entirely
pointless because would have queued up the missing events in the auth
chain to be fetched already.

Let's just diable the recursion, since it only gets called from one
place anyway.
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/7817.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/7817.bugfix b/changelog.d/7817.bugfix
new file mode 100644
index 0000000000..1c001070d5
--- /dev/null
+++ b/changelog.d/7817.bugfix
@@ -0,0 +1 @@
+Fix bug where Synapse fails to process an incoming event over federation if the server is missing too much of the event's auth chain.