diff options
| author | Patrick Cloke <clokep@users.noreply.github.com> | 2022-08-30 07:15:54 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-30 07:15:54 -0400 |
| commit | 303b40b988bc372a81fc1a3cf62d3f5d074970ff (patch) | |
| tree | 9fac44d56c449b7e11732f068283322ecb265386 /changelog.d | |
| parent | Speed up inserting `event_push_actions_staging`. (#13634) (diff) | |
| download | synapse-303b40b988bc372a81fc1a3cf62d3f5d074970ff.tar.xz | |
Do not wait for background updates to complete do expire URL cache. (#13657)
Media downloaded as part of a URL preview is normally deleted after two days. However, while a background database migration is running, the process is stopped. A long-running database migration can therefore cause the media store to fill up with old preview files. This logic was added in #2697 to make sure that we didn't try to run the expiry without an index on `local_media_repository.created_ts`; the original logic that needs that index was added in #2478 (in `get_url_cache_media_before`, as amended by 93247a424a5068b088567fa98b6990e47608b7cb), and is still present. Given that the background update was added before Synapse v1.0.0, just drop this check and assume the index exists.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/13657.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/13657.bugfix b/changelog.d/13657.bugfix new file mode 100644 index 0000000000..d314d9c52f --- /dev/null +++ b/changelog.d/13657.bugfix @@ -0,0 +1 @@ +Fix a long-standing bug that downloaded media for URL previews was not deleted while database background updates were running. |