diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2021-10-18 19:29:37 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-18 18:29:37 +0100 |
| commit | cc33d9eee205ab57ce562ac410c8912c14343134 (patch) | |
| tree | 0db7c742e979a57c276d26416a9f1e9f8982292b /changelog.d | |
| parent | Check *all* auth events for room id and rejection (#11009) (diff) | |
| download | synapse-cc33d9eee205ab57ce562ac410c8912c14343134.tar.xz | |
Check auth on received events' auth_events (#11001)
Currently, when we receive an event whose auth_events differ from those we expect, we state-resolve between the two state sets, and check that the event passes auth based on the resolved state. This means that it's possible for us to accept events which don't pass auth at their declared auth_events (or where the auth events themselves were rejected), leading to problems down the line like #10083. This change means we will: * ignore any events where we cannot find the auth events * reject any events whose auth events were rejected * reject any events which do not pass auth at their declared auth_events. Together with a whole raft of previous work, this is a partial fix to #9595. Fixes #6643. Based on #11009.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/11001.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11001.bugfix b/changelog.d/11001.bugfix new file mode 100644 index 0000000000..f51ffb3481 --- /dev/null +++ b/changelog.d/11001.bugfix @@ -0,0 +1 @@ + Fix a long-standing bug which meant that events received over federation were sometimes incorrectly accepted into the room state. |