diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2021-02-22 16:52:45 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-22 16:52:45 +0000 |
| commit | 0a363f9ca4b71187eb26b80dfa2cd72a35b1f8fd (patch) | |
| tree | deecf1c9a23fe74e2361758bd4ad11bf3e078659 /changelog.d | |
| parent | Clean up the user directory sample config section (#9385) (diff) | |
| download | synapse-0a363f9ca4b71187eb26b80dfa2cd72a35b1f8fd.tar.xz | |
Remove cache for get_shared_rooms_for_users (#9416)
This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed. The cache was added in https://github.com/matrix-org/synapse/pull/7785, but we forgot to ensure it was invalidated appropriately. Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/9416.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/9416.bugfix b/changelog.d/9416.bugfix new file mode 100644 index 0000000000..4d79cb2228 --- /dev/null +++ b/changelog.d/9416.bugfix @@ -0,0 +1 @@ +Fix a bug that caused multiple calls to the experimental `shared_rooms` endpoint to return stale results. \ No newline at end of file |