summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorNick Mills-Barrett <nick@beeper.com>2023-01-04 11:49:26 +0000
committerGitHub <noreply@github.com>2023-01-04 11:49:26 +0000
commitdb1cfe9c80a707995fcad8f3faa839acb247068a (patch)
tree691c711006765e770056d97db624043d5b87b781 /changelog.d
parentAdd experimental support for MSC3391: deleting account data (#14714) (diff)
downloadsynapse-db1cfe9c80a707995fcad8f3faa839acb247068a.tar.xz
Update all stream IDs after processing replication rows (#14723)
This creates a new store method, `process_replication_position` that
is called after `process_replication_rows`. By moving stream ID advances
here this guarantees any relevant cache invalidations will have been
applied before the stream is advanced.

This avoids race conditions where Python switches between threads mid
way through processing the `process_replication_rows` method where stream
IDs may be advanced before caches are invalidated due to class resolution
ordering.

See this comment/issue for further discussion:
	https://github.com/matrix-org/synapse/issues/14158#issuecomment-1344048703
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/14723.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/14723.bugfix b/changelog.d/14723.bugfix
new file mode 100644
index 0000000000..e1f89cee35
--- /dev/null
+++ b/changelog.d/14723.bugfix
@@ -0,0 +1 @@
+Ensure stream IDs are always updated after caches get invalidated with workers. Contributed by Nick @ Beeper (@fizzadar).