diff options
| author | Hillery Shay <shaysquared@gmail.com> | 2021-09-22 08:25:26 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-22 08:25:26 -0700 |
| commit | f78b68a96b1f179043b38b4109e09fa0a315643d (patch) | |
| tree | 385b7aaa1987b730e15eb396dedaa71d4ac0557c /changelog.d | |
| parent | Fix invalidating OTK count cache after claim (#10875) (diff) | |
| download | synapse-f78b68a96b1f179043b38b4109e09fa0a315643d.tar.xz | |
Treat "\u0000" as "\u0020" for the purposes of message search (message indexing) (#10820)
* add test to check if null code points are being inserted * add logic to detect and replace null code points before insertion into db * lints * add license to test * change approach to null substitution * add type hint for SearchEntry * Add changelog entry Signed-off-by: H.Shay <shaysquared@gmail.com> * updated changelog * update chanelog message * remove duplicate changelog * Update synapse/storage/databases/main/events.py remove extra space Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * rename and move test file, update tests, delete old test file * fix typo in comments * update _find_highlights_in_postgres to replace null byte with space * replace null byte in sqlite search insertion * beef up and reorganize test for this pr * update changelog * add type hints and update docstring * check db engine directly vs using env variable * refactor tests to be less repetetive * move rplace logic into seperate function * requested changes * Fix typo. * Update synapse/storage/databases/main/search.py Co-authored-by: reivilibre <olivier@librepush.net> * Update changelog.d/10820.misc Co-authored-by: Aaron Raimist <aaron@raim.ist> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: Aaron Raimist <aaron@raim.ist>
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/10820.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/10820.misc b/changelog.d/10820.misc new file mode 100644 index 0000000000..4373bf6f6b --- /dev/null +++ b/changelog.d/10820.misc @@ -0,0 +1 @@ +Fix a long-standing bug where an `m.room.message` event containing a null byte would cause an internal server error. \ No newline at end of file |